D26532: Don't use KWindowSystem on Android
Nicolas Fella
noreply at phabricator.kde.org
Wed Jan 8 20:14:36 GMT 2020
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
The usage of KWindowSystem is not relevant on Android. This saves us a dependency there.
Ideally we wouldn't build KPassivePopup at all there, but unfortunately it is public API. One could argue that such a break for non-functional API on Android could be okay.
TEST PLAN
Builds on Android and Linux
REPOSITORY
R289 KNotifications
BRANCH
nokwindowsystem
REVISION DETAIL
https://phabricator.kde.org/D26532
AFFECTED FILES
CMakeLists.txt
src/CMakeLists.txt
src/config-knotifications.h.cmake
src/kpassivepopup.cpp
To: nicolasfella, #frameworks, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200108/9332db8c/attachment.html>
More information about the Kde-frameworks-devel
mailing list