D26519: Show button respecting what is declared by KCModule

Kevin Ottens noreply at phabricator.kde.org
Wed Jan 8 10:09:23 GMT 2020


ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> meven wrote in kcmultidialog.cpp:217
> You can remove this line I think : no need to disable a hidden button, or enable a visible one.

Well, I think I wouldn't temper with the setVisible of helpButton at all. Just to keep the behavior in line with systemsettings and keep the old behavior. This is not what this patch is supposed to change anyway.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D26519

To: bport, ervin, meven, crossi, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200108/48236d07/attachment.html>


More information about the Kde-frameworks-devel mailing list