D17595: Upstream Dolphin's file rename dialog

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in renamefiledialog.h:48
> So, what should we rename `RenameFileDialog` to? `RenameFileDialog` or `RenameFileOverwrittenDialog` ? ;)
> 
> Anyway, why wait for KF6 since this is new API? Can't we rename it now?

Ah sorry, I've read now the commit message. Which means there is a typo in this TODO:

"... and the class RenameDialog to RenameFileOverwrittenDialog or similar."

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D17595_1

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: elvisangelaccio, lydia, dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200106/0f95c615/attachment-0001.html>