D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

[David Faure]

dfaure added a comment.


  Benchmarking is complex ;)
  
  1. you need to make sure both Qt and your benchmark are built with optimizations enabled (-O2)
  2. you need to actually use those 3 variables otherwise the compiler might optimize out their use. This could be testing their value (NOT with Q_ASSERT if you're in release mode!) and aborting if they don't have the expected value. They will, of course, but the compiler won't know that.
  
  Your current results indicate "54 times slower" ! But indeed on very small numbers...

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26366

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200106/f170f548/attachment.html>