D25117: file ioslave: stop copying as soon as the ioslave is killed

David Faure noreply at phabricator.kde.org
Sun Jan 5 17:37:05 GMT 2020


dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> jobtest.cpp:2075
> +    QThread::msleep(500);
> +    QVERIFY(!QFile::exists(destToCheck));
>  }

How about QTRY_VERIFY instead of a hardcoded 500ms sleep?

This way, if the file gets deleted after 100ms, we can move on.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25117

To: meven, #frameworks, dfaure, ngraham, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200105/f7cc313a/attachment.html>


More information about the Kde-frameworks-devel mailing list