D26412: [Kuit] Port QRegExp to QRegularExpression

Ahmad Samir noreply at phabricator.kde.org
Sat Jan 4 18:38:56 GMT 2020


ahmadsamir added a comment.


  In D26412#587395 <https://phabricator.kde.org/D26412#587395>, @dfaure wrote:
  
  > Unittest for this method added in https://commits.kde.org/ki18n/a92305a4c15ac361417eeb7b933682960c7545e1
  >  Please check your change passes the test.
  >  Extend as needed if you noticed other cases that need to be handled.
  
  
  I tried to figure out what a "tag without content" in salvageMarkup() would be (to extend the unit test), but couldn't figure it out; <br /> or <hr /> came to mind, but I am not that versed with translation stuff in KDE.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26412

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200104/a3e152d5/attachment.html>


More information about the Kde-frameworks-devel mailing list