D26416: Kicker/Documents optimization: Lazily build KFileItem

Aleix Pol Gonzalez noreply at phabricator.kde.org
Sat Jan 4 16:58:41 GMT 2020


apol added inline comments.

INLINE COMMENTS

> recentusagemodel.cpp:251
> +    auto getFileItem = [=] () {
> +        #if KIO_VERSION >= QT_VERSION_CHECK(5,57,0)
> +            // Avoid calling QT_LSTAT and accessing recent documents

I'm pretty sure we can/should depend on newer KF5. I'd say just update to 5.57 as the dependency on the root CMakeLists.txt.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26416

To: meven, #frameworks
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200104/94ed1060/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list