D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

Méven Car noreply at phabricator.kde.org
Sat Jan 4 11:49:59 GMT 2020


meven added inline comments.

INLINE COMMENTS

> broulik wrote in kfileitem.cpp:783
> This creates a `QFileInfo` for `canonicalFilePath` which blocks, so the cache doesn't help at all.

At least the mnttab reading business in KMountPoint::currentMountPoints is saved.

> anthonyfieroni wrote in kfileitem.cpp:787
> Empty mountPoints means no fstab.

Here I am using KMountPoint::currentMountPoints which uses mnttab which should be supported on *nix.
The part about android came from KMountPoint::currentMountPoints comment.

I was thing about merging the two KMountPoint::currentMountPoints and KMountPoint::possibleMountPoints for better accuracy.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26407

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200104/860d171a/attachment.html>


More information about the Kde-frameworks-devel mailing list