D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

David Faure noreply at phabricator.kde.org
Sat Jan 4 09:34:15 GMT 2020


dfaure added a comment.


  You just made me realize something.
  The setter is unused, but the getter is used in all cases, to lookup the builtin formats.
  
  So I just extended the unittests in https://commits.kde.org/ki18n/4f9d907fb8e8dba33aa80926d3b36ba12f30da04
  These tests do check the regexp in parseUiMarker, please rebase on top of them and check that they still pass.
  And you're right, "@info: tooltip" (with a space in the middle) wasn't parsed as a cue, so no problem.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26366

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200104/1de2bf3c/attachment.html>


More information about the Kde-frameworks-devel mailing list