D25117: file ioslave: stop copying as soon as the ioslave is killed

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dfaure wrote in jobtest.cpp:2171
> Always use QVERIFY() around spy.wait().
> Well, I'm assuming we actually expect the signal to be emitted :-)
> I would also remove the 500 then, the default value will be fine.

Why the short 500ms timeout? CI can be slow sometimes.

> file_unix.cpp:356
> +        }
> +        finished();
> +        return;

shouldn't this be error(KIO::ERR_USER_CANCELED) instead? It's not like the copy actually succeeded...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25117

To: meven, #frameworks, dfaure, ngraham, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200103/e8d9b22f/attachment.html>