D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Jan 2 19:35:28 GMT 2020


apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ahmadsamir wrote in kuitmarkup.cpp:412
> According to the QList docs, at() should be used for read-only access, it could be faster than [] and it never causes a detach.

I'd do these changes in a separate commit. Also adding consts to unrelated variables.

REPOSITORY
  R249 KI18n

BRANCH
  l-toKeyCombo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26360

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid, apol
Cc: apol, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200102/1ef433ae/attachment.html>


More information about the Kde-frameworks-devel mailing list