D26360: [Kuit] Port QRegExp to QRegularExpression, second pass

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Jan 2 12:27:14 GMT 2020


apol added inline comments.

INLINE COMMENTS

> kuitmarkup.cpp:412
>          // Normalize key, trim and all lower-case.
> -        QString nkey = keys[i].trimmed().toLower();
> +        const QString nkey = keys.at(i).trimmed().toLower();
>          keys[i] = keyNames.contains(nkey) ? keyNames[nkey].toString(languages)

Why did you change [i] to at(i)?

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26360

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: apol, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200102/5917aa76/attachment.html>


More information about the Kde-frameworks-devel mailing list