D25443: [chmodjob] Port away from QLinkedList

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Code looks good, just the comment needs a fix.
  
  [Too bad std::stack doesn't seem to have a reserve() method.]

INLINE COMMENTS

> chmodjob.cpp:188
>                            << "\n new permissions = " << QString::number(info.permissions,8);*/
>              // Prepend this info in our todo list.
>              // This way, the toplevel dirs are done last.

"Prepend" is confusing now since push is more of an append. This comment needs an update, like "Push this info on top of the stack so it's handled first"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25443

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200101/5ad95073/attachment.html>