D26292: [KSambaShare] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  In D26292#586025 <https://phabricator.kde.org/D26292#586025>, @dfaure wrote:
  
  > Now I'm completely confused. Did you just argue *against* your own change?
  >
  > You seem to say the old name was better...
  
  
  The original code, before I put my paws on it, used "noToMarchRx", I changed it to "badPattern", then changed it back, before you reviewed the diff at all; sorry about the confusion.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26292

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200101/1452951e/attachment.html>