D26339: [KFileWidgets] Port QRegExp to QRegularExpression

David Faure noreply at phabricator.kde.org
Wed Jan 1 17:36:50 GMT 2020


dfaure added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in kfilewidget.cpp:2458
> Declaring rx before the for-loop isn't more efficient? then inside the for-loop it's the same QRegularExpression object and setPattern() is called.

Hmm OK this isn't like QString, reusing rx saves allocating/deallocating its d pointer indeed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26339

To: ahmadsamir, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200101/0005a9c8/attachment.html>


More information about the Kde-frameworks-devel mailing list