D26171: Implement wp_viewporter

David Edmundson noreply at phabricator.kde.org
Wed Jan 1 16:43:22 GMT 2020


davidedmundson added inline comments.

INLINE COMMENTS

> romangg wrote in surface_interface.cpp:882
> How I read the spec: the source rectangle is always specified in coordinates after scale and transform. [1]
> 
> `SurfaceInterface::size()` returns the scaled and transformed (not yet) buffer size so since viewporter coordinates are to this base we can just directly return them.
> 
> [1] https://gitlab.freedesktop.org/wayland/wayland-protocols/blob/master/stable/viewporter/viewporter.xml#L103

Yeah, on re-reading I think your intepretation is right. Leave your stuff as-is.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26171

To: romangg, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200101/678ed430/attachment.html>


More information about the Kde-frameworks-devel mailing list