D21795: [KAuth] Add support for action details in Polkit1 backend.

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  Much better. Since nobody has input on the deprecations I guess they must be alright. Do have a look into using QDBusError::InvalidArgs before landing though.

INLINE COMMENTS

> DBusHelperProxy.cpp:120
>          if (reply.type() == QDBusMessage::ErrorMessage) {
> +            if (reply.errorName() == QStringLiteral("org.freedesktop.DBus.Error.InvalidArgs")) {
> +                // For backwards compatibility if helper binary was built with older KAuth version.

Probably better to us the abstraction enum `if (watcher->error().type() == QDBusError::InvalidArgs) {`

> kauthaction.h:108
> +     */
> +    enum AuthDetail {
> +        DetailOther = 0,

consider enum class

REPOSITORY
  R283 KAuth

BRANCH
  arcpatch-D21795_1

REVISION DETAIL
  https://phabricator.kde.org/D21795

To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, chinmoyr
Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200228/c0800d4a/attachment.html>