D27695: WIP: Create a new TopArea element using widgets/toparea svg

Arjen Hiemstra noreply at phabricator.kde.org
Thu Feb 27 11:06:36 GMT 2020


ahiemstra added inline comments.

INLINE COMMENTS

> TopArea.qml:40
> +    rightInset: -topAreaSvg.margins.right
> +    topInset: -topAreaSvg.margins.bottom ? flipped : -topAreaSvg.margins.top
> +    bottomInset: -topAreaSvg.margins.bottom ? flipped : -topAreaSvg.margins.top

This conditional is wrong. The syntax is `condition ? true_case : false_case` so you want to write `flipped ? -topAreaSvg.margins.top : -topAreaSvg.margins.bottom` or something similar.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200227/51440a5d/attachment.html>


More information about the Kde-frameworks-devel mailing list