D27502: Create ConfigView an unmanaged ConfigWidget

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> settings.cpp:62
>  
> -bool Settings::setCheckUppercase(bool check)
> +void Settings::setSkipUppercase(bool check)
>  {

Rename the parameter to skip as well please

> settingsimpl.cpp:260
>      //same defaults are in the default filter (filter.cpp)
> -    d->checkUppercase = settings.value(QStringLiteral("checkUppercase"), true).toBool();
> -    d->skipRunTogether = settings.value(QStringLiteral("skipRunTogether"), true).toBool();
> +    d->checkUppercase = settings.value(QStringLiteral("checkUppercase"), Settings::defaultSkipUppercase()).toBool();
> +    d->skipRunTogether = settings.value(QStringLiteral("skipRunTogether"), Settings::defauktSkipRunTogether()).toBool();

I'd expect a negation here... if by default skip is false, check in settingsimpl should be true (which was the old default).

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D27502

To: bport, #plasma, ervin, crossi, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200227/0914a7a3/attachment.html>