D27671: Dialog: disconnect from QWindow signals in destructor

[Daniel Vrátil]

dvratil created this revision.
dvratil added reviewers: Plasma, nicolasfella.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dvratil requested review of this revision.

REVISION SUMMARY
  When Dialog is being destroyed, its QWindow super-class may still emit
  some signals from its destructor. Dialog is connected so some of them,
  so this leads to Qt invoking slots on Dialog, whose destructor has
  already been called, leading to crashes.
  
  This patch disconnects all internal connections in Dialog's destructor.
  
  See https://phabricator.kde.org/D23339 for details.

TEST PLAN
  Plasma no longer crashes when a notification appears

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27671

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: dvratil, #plasma, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200226/8ad0b700/attachment-0001.html>