D27654: [kio] Fix running konsole on Wayland

[David Faure]

dfaure added a comment.


  Since this is konsole specific, it's fine to use a Qt-specific argument.
  But IMHO you could also just remove the %i altogether.
  I never understood the idea of "take the icon from the desktop file, not the one the application would use by default".
  I mean, with some stretch of the imagination I can see N desktop files launching the same app with different options including the icon (why not...), but not like here where it will just look up the default konsole.desktop anyway.
  
  Wait, you're actually passing the icon of the command being executed now (while the old code would end up using the stuff from konsole.desktop I think)....
  But it gets worse, konsole is a unique-application by default, isn't it? So this icon will never show, unless this is the first app that starts konsole -- and then all subsequent apps will end up with that icon of the first command.... This is all nonsense to me....
  
  Option 1: remove %i
  Option 2: test all the scenarios above... (icon in app desktop file + konsole not already running, then launching konsole again ; icon in app desktop file + konsole already running with default parameters)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27654

To: wbauer, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200225/83353c29/attachment.html>