D27616: [UrlHandler] optimise the code and less if nesting
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Tue Feb 25 17:53:17 GMT 2020
apol added inline comments.
INLINE COMMENTS
> ahmadsamir wrote in urlhandler.cpp:55
> I could be wrong, but this is exactly equivalent to the original code, i.e. it won't reach this unless helpcenter is empty and it's not a kde app... and I actually wanted to ask about this bit from the original code, what is it supposed to do?
I guess it was in case it wasn't found. Maybe just change into an error saying "can't open the following help url %1" where %1 is the url
REPOSITORY
R273 KGuiAddons
REVISION DETAIL
https://phabricator.kde.org/D27616
To: ahmadsamir, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200225/603b9f81/attachment.html>
More information about the Kde-frameworks-devel
mailing list