D27586: templates: Convert license statements to SPDX headers

Andreas Cord-Landwehr noreply at phabricator.kde.org
Tue Feb 25 17:49:11 GMT 2020


cordlandwehr accepted this revision.
cordlandwehr added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kossebau wrote in main.cpp:31
> Hmpf, that slipped me. The regular expression overdoing its job :)
> I guess that will be hit in more KAboutData instances. Perhaps ignoring hits which are enclosed by " might filter this properly?
> Also should no space be added possibly if <contact> is missing?

using the `"` as enclosed flags sounds to be a nice pragmatic approach

REPOSITORY
  R306 KParts

BRANCH
  spdxlicensefortemplate

REVISION DETAIL
  https://phabricator.kde.org/D27586

To: kossebau, cordlandwehr, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200225/61464d68/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list