D27616: [UrlHandler] optimise the code and less if nesting

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Feb 24 16:16:16 GMT 2020


apol added a comment.


  LGTM otherwise

INLINE COMMENTS

> urlhandler.cpp:55
> +        // not a KDE application
> +        QDesktopServices::openUrl(u);
>      }

won't this recurse forever?

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D27616

To: ahmadsamir, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200224/8b31ae2d/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list