D27557: Auto-generate 24px monochrome icons

[Harald Sitter]

sitter added a comment.


  Oh, oh boy, there's many more things wrong with this than just the bashism :|
  
  @ndavis @ngraham why don't you generate the 24x version inside the source?
  
  `        COMMAND ${BASH_EXE} ${CMAKE_SOURCE_DIR}/generate-24px-versions.sh ${BREEZE_INSTALL_DIR}` this is bypassing make DESTDIR control, which will make this entire thing unpackable. It'll also outright not work if the target dir is not writable by the user running make (e.g. as is the case during packaging or when a user builds for /usr/local).
  
  There's also a var interpolation bug here: `    OUTPUT_FILE="$OUTPUT_DIR/${INPUT_FILE/22/24}"` (mind the INPUT_FILE expansion closing way after the var name ended)
  
  I'm installing freebsd now to find my way to a fix ^^

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: bcooksley, kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200224/ef13579c/attachment.html>