D27607: Deprecate KDBusConnectionPool

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> CMakeLists.txt:45
> +    DEPRECATION_VERSIONS 5.68
> +    EXCLUDE_DEPRECATED_BEFORE_AND_AT ${EXCLUDE_DEPRECATED_BEFORE_AND_AT}
> +)

`${EXCLUDE_DEPRECATED_BEFORE_AND_AT}` is not defined by default.

You want to add an option (or actually cached cmake var) in the toplevel CMakeLists.txt, lke mentioned in the docs: https://api.kde.org/ecm/module/ECMGenerateExportHeader.html
Both to document this flag, as also ensure there the variable is set (did cmake not fail for you?):

  set(EXCLUDE_DEPRECATED_BEFORE_AND_AT 0 CACHE STRING "Control the range of deprecated API excluded from the build [default=0].")

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D27607

To: vkrause
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200223/dd3be30b/attachment.html>