D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

[Méven Car]

meven added a comment.


  In D27539#615654 <https://phabricator.kde.org/D27539#615654>, @dfaure wrote:
  
  > This is about an icon name. Apps don't (shouldn't) "check the value".
  >
  > We should return application-octet-stream if we did find the file, but mimetype determination failed. That's what this mimetype and its icon are about.
  >
  > We should return unknown if we have no clue what that URL is.
  
  
  So unless I am mistaken, you are saying the current behavior is the correct, one. And I can go with it.
  The code does :
  
  - if no scheme "unkwown"
  - else a bunch of rules, islocalFile, KFileItem handling, http, trash, KProtocolInfo::icon...
  - else whatever db.mimeTypeForUrl(url) returns (worse case application-octet-stream)
  
  Feel free to accept the diff ;)

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D27539

REVISION DETAIL
  https://phabricator.kde.org/D27539

To: meven, ngraham, #frameworks, dfaure, broulik, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200222/f255ee6b/attachment.html>