D27540: Status indicator for individual widgets in KCModule
Méven Car
noreply at phabricator.kde.org
Fri Feb 21 11:24:25 GMT 2020
meven added inline comments.
INLINE COMMENTS
> kconfigdialogmanager_p.h:60
> + QHash<QString, QWidget *> buddyWidget;
> + QHash<QString, SettingStatusIndicator *> indicatorWidget;
> + QSet<QWidget *> allExclusiveGroupBoxes;
I would have named those with s : indicatorWidgets, knownWidgets, buddyWidgets
> settingsstatusindicator_p.h:41
> + bool isDefaulted() const;
> + void setDefaulted(bool defaulted);
> +
Make setChanged and setDefaulted as slots to ease the reuse of this class outside of KConfigDialogManager
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D27540
To: ervin, ngraham, davidedmundson, meven, crossi, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200221/ad1939b9/attachment.html>
More information about the Kde-frameworks-devel
mailing list