D26983: Enable adding place as first child
George Vogiatzis
noreply at phabricator.kde.org
Thu Feb 20 20:48:58 GMT 2020
gvgeo added a comment.
After some digging, I found that KBookmarkGroup has more items that the KFilePlacesModel.
It is impossible to make `KBookmark` move at the end of a `BookmarkGroup`, if the item is not in the `KFilePlacesModel`.
I don't see a better solution than the current revision of the patch. (Assuming that my proposed change of using null as first item is acceptable.)
index: KBookmarkGroup -> KFilePlacesModel
0 : "Home" -> "Home"
1 : "Desktop" -> "Desktop"
2 : "Network" -> "Trash"
3 : "Trash" -> "Downloads"
4 : "Recent Files" -> "kde"
5 : "Recent Locations" -> "config"
6 : "Modified Today" -> "Templates"
7 : "Modified Yesterday" -> "Sync"
8 : "Documents" -> "Pictures"
9 : "Images" -> "Network"
10 : "Audio" -> "Recent Files"
11 : "Videos" -> "Recent Locations"
12 : "--- separator ---" -> "--- separator ---"
13 : "--- separator ---" -> "--- separator ---"
14 : "--- separator ---" -> "--- separator ---"
15 : "--- separator ---" -> "--- separator ---"
16 : "--- separator ---" -> "--- separator ---"
17 : "Downloads"
18 : "kde"
19 : "config"
20 : "--- separator ---"
21 : "--- separator ---"
22 : "Templates"
23 : "Sync"
24 : "--- separator ---"
25 : "Pictures"
26 : "--- separator ---"
27 : "--- separator ---"
28 : ""
REPOSITORY
R241 KIO
BRANCH
after (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26983
To: gvgeo, #frameworks, meven, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200220/c81fde28/attachment.html>
More information about the Kde-frameworks-devel
mailing list