D27463: KconfigXT: Add a value attribute to Enum field choices

Cyril Rossi noreply at phabricator.kde.org
Thu Feb 20 10:30:46 GMT 2020


crossi added inline comments.

INLINE COMMENTS

> meven wrote in KConfigXmlParser.cpp:203
> If you don't mind I am putting aside the second part as it is not directly related to this PR, i.e name attribute validation. (FYI we had KConfigXmlParser::validateNameAndKey)

I guess there are more problematic characters. IMO this is not the right place, you pointed `validateNameAndKey()` which seems to be a better choice to implement such checks.

BTW, this is not related to this PR.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27463

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200220/73130c6b/attachment.html>


More information about the Kde-frameworks-devel mailing list