D27497: Fix code generation for entries with min/max

Méven Car noreply at phabricator.kde.org
Thu Feb 20 10:10:09 GMT 2020


meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Seems good to me

INLINE COMMENTS

> test_param_minmax.h.ref:25
> +      {
> +        qDebug() << "setFoo: value " << v << " is less than the minimum value of 0.01";
> +        v = 0.01;

We probably should not output anything or at least let the user give logging context to the debug output.
This is not about this review though.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27497

To: hchain, meven, crossi, ervin, bport, tcanabrava
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200220/098cf2e2/attachment.html>


More information about the Kde-frameworks-devel mailing list