D27083: [PC2]Give Label integer width.

David Edmundson noreply at phabricator.kde.org
Tue Feb 18 17:31:04 GMT 2020


davidedmundson added a comment.


  From a logical viewpoirnt it doesn't make sense. It's a binding loop. Changing the width will re-lay out, which will change the paintedWidth, which will change the width.
  Practically QQuickTextItem has a catch against that (see qquicktext.cpp: internalWidthUpdate)  and it will stop after the first pass without a warning.
  
  But I don't really understand how this helps anything in a reliable way.
  Layouts will override widths after a layout invalidation. Correctly set anchors would override it.
  It's almost always wrong for a component to set it's own size (as opposed to it's implict size) as the consumer of the API will inevitably change it
  
  Also, why is only PC2 affected?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27083

To: gvgeo, #plasma, #vdg, ndavis, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200218/81f1b0de/attachment.html>


More information about the Kde-frameworks-devel mailing list