D27460: fix layout size hints for button labels

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> mart wrote in button3.qml:90
> added

You didn't even run this :(

1. icon.name not icon.source
2. now the comment next to it is wrong
3. there's a binding loop

4. if I make a test without any text, which is what the thing you're supposedly fixing was doing, I don't get an icon

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27460

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200218/2dd13d6d/attachment-0001.html>