D27476: [KDBusConnectionPool] Handle the case of no qApp
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Tue Feb 18 15:16:40 GMT 2020
apol added inline comments.
INLINE COMMENTS
> kdbusconnectionpool.cpp:66
> + if (!QCoreApplication::instance()) {
> + return QDBusConnection::sessionBus();
> + }
It feels like we should be using the s_perThreadConnection when we're not on a QApplication. Non-QApplications might still have threads.
REPOSITORY
R271 KDBusAddons
REVISION DETAIL
https://phabricator.kde.org/D27476
To: davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200218/377f9ba7/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list