D27451: Drop KToolInvocation support from KRun::runService

David Edmundson noreply at phabricator.kde.org
Mon Feb 17 08:56:38 GMT 2020


davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This drops the use of kinit as per T12140 <https://phabricator.kde.org/T12140>. Few applications link to
  kdeinit correctly and the potential savings that come from library 
  linking are now negligible.
  
  We use the internal app spawning path for the majority of application
  launches anyway via the relatively new KRun::runApplication. There isn't
  a need for runService to support a more complex addition path.
  
  It will also simplify any future changes coming to KRun.

TEST PLAN
  Opened a file from kicker's recently used selection (which uses this runService)
  It opened as normal, with correct startup notifications

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27451

AFFECTED FILES
  src/widgets/krun.cpp

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200217/2d39f0af/attachment.html>


More information about the Kde-frameworks-devel mailing list