D26749: WIP: Support NDK r20 and Qt 5.14
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Sat Feb 15 21:41:05 GMT 2020
apol added a comment.
Patch makes sense to me overall, we could consider landing it.
INLINE COMMENTS
> vkrause wrote in Android.cmake:173
> It's "better" in the way that it actually works with NDK r20, while CMake 3.16 failed to even pass the basic compiler checks. For a toolchain file shipped with a toolchain making adjustments for toolchain changes is of course possible immediately, while with CMake we have to wait for the next release if such changes are necessary.
>
> It's unfortunately different in various variable names as well in some details of what it sets or doesn't set. That's where most of the changes in this file come from.
>
> The main reason we didn't use this right from the start, and probably also the reason the toolchain file in CMake exists is that the NDK didn't have CMake support in older versions.
I did some testing and for me it works for arm64 but not for arm32.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D26749
To: vkrause
Cc: flherne, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200215/66f4ce87/attachment.html>
More information about the Kde-frameworks-devel
mailing list