D27357: Fix infinite recursion in xscreensaver plugin

Aleksei Nikiforov noreply at phabricator.kde.org
Thu Feb 13 13:32:11 GMT 2020


alnikiforov added a comment.


  In D27357#610605 <https://phabricator.kde.org/D27357#610605>, @broulik wrote:
  
  > Neither the XSync nor the windows backend explicitly call `resumingFromIdle` in `simulateUserActivity`, so I think this should be fine.
  >  However, I don't know if that won't indirectly trigger it if the session was idle? Maybe we need to check if the session was idle and only then emit the signal.
  
  
  I'm not sure how exactly it works, but if session was idle, wouldn't function `screensaverActivated` be called on changing state? And it contains `emit resumingFromIdle()`:
  
  https://phabricator.kde.org/source/kidletime/browse/master/src/plugins/xscreensaver/xscreensaverbasedpoller.cpp$37

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D27357

To: alnikiforov, davidedmundson, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200213/2a11841e/attachment.html>


More information about the Kde-frameworks-devel mailing list