D27245: Ki18n: Convert license headers to SPDX statements

Christophe Giboudeaux noreply at phabricator.kde.org
Thu Feb 13 10:34:14 GMT 2020


cgiboudeaux added a comment.


  some headers have 3 leading whitespaces, some 4. Can you clarify?

INLINE COMMENTS

> LGPL-3.0-only.txt:15-17
> +
> +      
> +

why are there so many empty lines?

> gettext.h:2
>  /* Convenience header for conditional use of GNU <libintl.h>.
> -   Copyright (C) 1995-1998, 2000-2002, 2004-2006 Free Software Foundation, Inc.
> -
> -   This program is free software; you can redistribute it and/or modify it
> -   under the terms of the GNU Library General Public License as published
> -   by the Free Software Foundation; either version 2, or (at your option)
> -   any later version.
> -
> -   This program is distributed in the hope that it will be useful,
> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -   Library General Public License for more details.
> -
> -   You should have received a copy of the GNU Library General Public
> -   License along with this program; if not, write to the Free Software
> -   Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301,
> -   USA.  */
> +   SPDX-FileCopyrightText: 1995-1998, 2000-2002, 2004-2006 Free Software Foundation , Inc.
> +

extra space after "Free Software Foundation"

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D27245

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200213/6c7ff0de/attachment.html>


More information about the Kde-frameworks-devel mailing list