D27355: POC: Make kstatusnotifieritem available without dbus

[Ben Cooksley]

bcooksley added inline comments.

INLINE COMMENTS

> kstatusnotifieritem.cpp:48
> +
> +#include <QTimer>
>  #include <kwindowinfo.h>

New header?

> kstatusnotifieritem.cpp:617
>  void KStatusNotifierItem::showMessage(const QString &title, const QString &message, const QString &icon, int timeout)
>  {
>  #ifdef Q_OS_MACOS

Won't this mean that showMessage() is a no-op on Windows systems without D-Bus?
I would have thought that systemTrayIcon->showMessage() should be used here as well?

> kstatusnotifieritem.cpp:888
>  {
> +    bool useLegacy = false;
> +#ifdef QT_DBUS_LIB

From my reading of the setLegacySystemTrayEnabled() won't setting it to false explicitly disable any form of system tray icon?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27355

To: vonreth, bcooksley, jjazeix
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200213/b796b9fb/attachment-0001.html>