D27299: Vertically center tooltip icon/image
Nathaniel Graham
noreply at phabricator.kde.org
Mon Feb 10 17:57:35 GMT 2020
ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Right now the widget tooltip's icon/image is top-aligned, which in practice makes it
vertically centered when the tooltip has only one line of text, but not vertically
centered when there are two lines of text.
This patch makes it vertally centered all the time, improving the appearance.
TEST PLAN
Before: F8095695: Before.png <https://phabricator.kde.org/F8095695>
After: F8095696: After.png <https://phabricator.kde.org/F8095696>
F8095697: Better everywhere.mp4 <https://phabricator.kde.org/F8095697>
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
vertically-center-tooltip-icon (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27299
AFFECTED FILES
src/declarativeimports/core/private/DefaultToolTip.qml
To: ngraham, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200210/ba5321ed/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list