D27294: fix free space calculation

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  - collapse statvfs call, there's no purpose in manually opening the file when libsmbc has a convenience wrapper that does exactly what we need with less code on our end
  - blockSize is now calculated as per the conditional branches in smbc_stat.c
  - free space calculation is now backwards compatible with slightly busted legacy versions of libsmbc not setting f_bavail
  
  FIXED-IN: 19.12.3
  BUG: 298801

TEST PLAN
  free space calculation now works with windows10, ubuntu18.04, ubuntu19.10

REPOSITORY
  R320 KIO Extras

BRANCH
  bug298801

REVISION DETAIL
  https://phabricator.kde.org/D27294

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200210/b3e6637f/attachment-0001.html>