D26888: work around to fully support the windows backend
Albert Vaca Cintora
noreply at phabricator.kde.org
Sun Feb 9 19:21:49 GMT 2020
albertvaka added inline comments.
INLINE COMMENTS
> notifybysnore.cpp:135-139
> + if (id == -1) {
> + emit actionInvoked(0, actionNum);
> + } else {
> + emit actionInvoked(id, actionNum);
> + }
This could become:
if (id == -1) {
id = 0
}
emit actionInvoked(id, actionNum);
To not duplicate the emit line. Still, it feels hackish.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D26888
To: brute4s99, vonreth, broulik, #kde_connect
Cc: albertvaka, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200209/687e7039/attachment.html>
More information about the Kde-frameworks-devel
mailing list