D27216: [KProcessRunner] Improve error reported to user when exit code != 0

[Ahmad Samir]

ahmadsamir requested review of this revision.
ahmadsamir added a comment.


  krununittest fails to pass, I tried to debug it but can't get it to work. Disabling the third row "QTest::newRow("tempfile") << true << false;" in KRunUnitTest::KRunRunService_data, makes it pass... I can't figure it out.
  
    31: PASS   : KRunUnitTest::KRunRunService(standard)
    31: command= "cp %f %d/dest" args= ("cp %f %d/dest", "file:///tmp/krununittest-lvuRpo/srcfile")
    31: EXEC "/usr/bin/cp /tmp/krununittest-lvuRpo/srcfile /tmp/krununittest-lvuRpo//dest"
    31: EXEC done
    31: sleeping for 180 seconds before deleting file...
    31: PASS   : KRunUnitTest::KRunRunService(tempfile)
    31: QWARN  : KRunUnitTest::KRunRunService(runApp) "The executable 'cp' terminated abnormally.\nFor more details try running it from a terminal emulator (e.g. Konsole)."
    31: QFATAL : KRunUnitTest::KRunRunService(runApp) QWidget: Cannot create a QWidget without QApplication
    31: FAIL!  : KRunUnitTest::KRunRunService(runApp) Received a fatal error.
    31:    Loc: [Unknown file(0)]
    31: Totals: 30 passed, 1 failed, 0 skipped, 0 blacklisted, 387ms
    31: ********* Finished testing of KRunUnitTest *********
    1/1 Test #31: kiowidgets-krununittest ..........Child aborted***Exception:   0.40 sec
  
  And jobtest fails with:
  8: FAIL!  : JobTest::moveDestAlreadyExistsAutoRename(files other partition) Compared values are not the same
  8:    Actual   (spyRenamed.count()): 3
  8:    Expected (2)                 : 2
  8:    Loc: [/home/ahmad/rpmbuild/dev/kio/autotests/jobtest.cpp(1656)]
  
  and the same with "(dirs other partition)", but that is unrelated AFAICS.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27216

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200209/b2d8da52/attachment-0001.html>