D27148: update d->m_file in ReadOnlyPart::setUrl()

David Faure noreply at phabricator.kde.org
Fri Feb 7 22:24:06 GMT 2020


dfaure added a comment.


  I'm OK with "only" a documentation fix at the KParts level. If you reimplement openUrl, you get to handle that URL, obviously. That includes possibly doing the async job that resolves it to a local file path.
  
  "making ReadOnlyPart::setUrl() set d->m_file if the url is a local file" would be fine if you mean QUrl::isLocalFile(), but NOT if you mean another KJob::exec(). So it wouldn't help.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D27148

To: pdabrowski, elvisangelaccio, ngraham, #frameworks, dfaure
Cc: ahmadsamir, marten, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200207/f578c064/attachment.html>


More information about the Kde-frameworks-devel mailing list