D27204: Fix the KNSQuick Dialog's close title and basic layout

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This resolves several issues found in the KNSQuick Dialog component.
  
  Specifically it puts a background in the dialog (as a rectangle),
  since the QtQuick Dialogs base dialog lacks such a thing by default,
  and offers no background property to rectify it.
  
  It further changes the Close button from a custom one to using a
  default button provided by the various underlying systems. This
  is more fault proof than the previous incarnation, but requires
  that the escape button press is handled separately.
  
  Finally it sets a sensible default size (previously the dialog
  was made large by the layout, but as a side effect of the layouting
  now being done without a Layout (which we could, but which would make
  the code enormously convoluted for little gain), we can now set a
  set of implicit width and height on the content item, which results
  in both a sensible default size and a dialogue that will resize down
  the way one would expect it to).
  
  This could have been done as separate patches, but they're too
  intertwined for that to feel in any way reasonable to do...
  
  BUG:415606
  BUG:416354
  BUG:414682

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-dialog-background-and-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27204

AFFECTED FILES
  src/qtquick/qml/Dialog.qml

To: leinir
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200207/f7c6c4a0/attachment-0001.html>