D27158: Fix some compiler warnings

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, apol.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  - Fix order of member initialisation (compiling with -Wreorder)
  - Use Q_UNUSED where needed
  - QAtomicInteger::loadRelaxed() has been available since Qt 5.14

TEST PLAN
  make && ctest

REPOSITORY
  R237 KConfig

BRANCH
  l-compiler-warnings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27158

AFFECTED FILES
  src/core/kconfig.cpp
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200204/5e675fc8/attachment.html>