D27017: [KColorUtils] Add hue(), chroma() and getHcyColor()

Matthew Woehlke noreply at phabricator.kde.org
Mon Feb 3 22:07:28 GMT 2020


mwoehlke added inline comments.

INLINE COMMENTS

> broulik wrote in kcolorutils.h:42
> This doesn't mention hcy anywhere and there's `QColor::hue`. 
> But we already have `luma` in the same way, so I guess this is alright.

I expect it wouldn't hurt to mention that `luma`, `chroma` and `hue` all work in //linear// color space. (I expect this is the reason `KHCY` and `QColor` produce different answers.)

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D27017

To: ndavis, #frameworks, dfaure
Cc: mwoehlke, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200203/94bc4d08/attachment.html>


More information about the Kde-frameworks-devel mailing list