D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove added inline comments.

INLINE COMMENTS

> davidedmundson wrote in metadata.desktop.cmake:98
> There's an explicit comment on why this is as it is.
> 
> That needs some addressing as to why it no longer applies or is less important that some other change.

Simply put, it doesn't work. I opened a bug about it https://bugs.kde.org/show_bug.cgi?id=416699. It results in weird colors that have nothing to do with the background. If I understood it correctly, it's supposed to tweak the value based on the background darkness in order to make the background more light in those cases and preserving readability, but that does not seem to work either as there are some places in the 'before' screenshots that look way too dark, and are instead much more readable with this patch.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove
Cc: davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ndavis, ZrenBot, firef, ngraham, bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200203/7ccd7947/attachment.html>