D27112: Fix errors in the QRegularExpression porting commit

Ahmad Samir noreply at phabricator.kde.org
Sun Feb 2 22:12:20 GMT 2020


ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, drosca, apol, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Properties::parse():
  
  - The regex is case sensitive
  - Fix copy/paste error, it's just one space " "
  
  Fix porting of capturedTexts().last() of QRegExp; it should be match.captured(1)
  with QRegularExpression if there's one capturing group in the pattern;
  QRegExp capturedTexts() first element is the 0 capturing group which
  captures the whole matched string.

REPOSITORY
  R269 BluezQt

BRANCH
  l-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27112

AFFECTED FILES
  tools/bluezapi2qt/CppGenerator.cpp
  tools/bluezapi2qt/Interface.cpp
  tools/bluezapi2qt/Method.cpp
  tools/bluezapi2qt/Properties.cpp

To: ahmadsamir, #frameworks, drosca, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200202/d4c27b50/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list