D25117: file ioslave: stop copying as soon as the ioslave is killed

Méven Car noreply at phabricator.kde.org
Sun Feb 2 18:19:43 GMT 2020


meven added inline comments.

INLINE COMMENTS

> jobtest.cpp:82
> +    // to make sure io is not too fast
> +    qputenv("KIOSLAVE_FILE_ENABLE_TESTMODE", "1");
> +

It'd be nice to have an #idef BUILD_TEST to only include this code path only when tests are compiled.
I didn't know how to achieve this.

> dfaure wrote in jobtest.cpp:2045
> Does this mean the file could be made smaller again?
> 
> (to reduce disk-space requirements)

I have reduced the size space needed to a smaller value than before this patch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25117

To: meven, #frameworks, dfaure, ngraham, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200202/82b1a56b/attachment.html>


More information about the Kde-frameworks-devel mailing list